Issue 1445 vaultdefaultlease #1446
Conversation
|
|
nritholtz
force-pushed
the
issue-1445-vaultdefaultlease
branch
from
fca68ad to
8817db9
Compare
nritholtz
force-pushed
the
issue-1445-vaultdefaultlease
branch
from
8817db9 to
8aa8069
Compare
|
Definitively what I was looking for ! GG. |
|
Thanks for the PR @nritholtz and for chiming in @vfoucault! We've been focused on the development of a new project and are preparing for it's initial release. Once out we'll have more time for our other projects again and we'll get these PRs reviewed. |
| @@ -852,6 +852,9 @@ func (r *Runner) init() error { | |||
| } | |||
| log.Printf("[DEBUG] (runner) final config: %s", result) | |||
|
|
|||
| //Set VaultDefaultLeaseDuration | |||
| dep.VaultDefaultLeaseDuration = config.TimeDurationVal(r.config.Vault.DefaultLeaseDuration) | |||
There was a problem hiding this comment.
Not a huge fan of using a module/global variable for this but there is no other good place for now. That is I'm considering this OK for the merge but will probably want to revisit this later... maybe when I port it to hashicat.
Consider this more an internal note to myself than anything that needs to be changed here.
eikenb
added
hashicat-update-required
|
I had to do the PR locally and worked on it there such that github doesn't recognize it as this PR. Closing with |
Add support for vault default_lease_duration
Addresses #1445
Wanted to get the conversation going, so I am definitely OK with making changes.